Return-Path: 
 <dev-return-14400-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5E23C18AB7
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Mon, 28 Mar 2016 14:09:37 +0000 (UTC)
Received: (qmail 79084 invoked by uid 500); 28 Mar 2016 14:09:37 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 79041 invoked by uid 500); 28 Mar 2016 14:09:37 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 79030 invoked by uid 99); 28 Mar 2016 14:09:36 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Mar 2016 14:09:36 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D634ADFDE0; Mon, 28 Mar 2016 14:09:36 +0000 (UTC)
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-82-accumulo@git.apache.org>
In-Reply-To: <git-pr-82-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: 4148 inmemorymap counter
Content-Type: text/plain
Message-Id: <20160328140936.D634ADFDE0@git1-us-west.apache.org>
Date: Mon, 28 Mar 2016 14:09:36 +0000 (UTC)

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/82#discussion_r57574776
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java ---
    @@ -202,10 +203,26 @@ public InMemoryMap(Map<String,Set<ByteSequence>> lggroups, boolean useNativeMap,
         this.memDumpDir = memDumpDir;
         this.lggroups = lggroups;
     
    -    if (lggroups.size() == 0)
    +    if (lggroups.size() == 0) {
           map = newMap(useNativeMap);
    -    else
    +      mapType = useNativeMap ? "NativeMapWrapper" : "DefaultMap";
    --- End diff --
    
    Using constants here would be nice (and could be re-used in your test)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---