accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivakegg <>
Subject [GitHub] accumulo pull request: Accumulo 4169 - context cleanup
Date Thu, 31 Mar 2016 13:29:23 GMT
Github user ivakegg commented on a diff in the pull request:
    --- Diff: start/src/main/java/org/apache/accumulo/start/classloader/vfs/
    @@ -189,13 +189,13 @@ public ClassLoader getClassLoader(String contextName) throws FileSystemException
    -  public void removeUnusedContexts(Set<String> inUse) {
    +  public void removeUnusedContexts(Set<String> configuredContexts) {
    --- End diff --
    badly named.....we are not removing unused contexts here, we are removing from the list
of unused contexts.  Perhaps simply calling this removeConfiguredContexts or removeUsedContexts
would make more sense.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message