accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: [ACCUMULO-4147] - Add Accumulo Namespace Op...
Date Tue, 29 Mar 2016 13:10:02 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/74#discussion_r57719491
  
    --- Diff: test/src/main/java/org/apache/accumulo/test/proxy/SimpleProxyBase.java ---
    @@ -818,6 +950,58 @@ public void tableNotFound() throws Exception {
       }
     
       @Test
    +  public void namespaceNotFound() throws Exception {
    +    final String doesNotExist = "doesNotExists";
    +    try {
    +      client.deleteNamespace(creds, doesNotExist);
    --- End diff --
    
    If this thrift call does not throw a NNFE, it seems like the test will still pass?  If
this is the case, could place an Assert.fail() after each thrift call thats supposed to throw.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message