accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: 4148 inmemorymap counter
Date Mon, 28 Mar 2016 16:19:02 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/82#discussion_r57590769
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java ---
    @@ -202,10 +203,26 @@ public InMemoryMap(Map<String,Set<ByteSequence>> lggroups,
boolean useNativeMap,
         this.memDumpDir = memDumpDir;
         this.lggroups = lggroups;
     
    -    if (lggroups.size() == 0)
    +    if (lggroups.size() == 0) {
           map = newMap(useNativeMap);
    -    else
    +      mapType = useNativeMap ? "NativeMapWrapper" : "DefaultMap";
    --- End diff --
    
    I just saw that `mapType()` was invoked in the test and assumed that there was a corresponding
assertion on the value at some point. Thanks for making these constants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message