accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4112 use metadata table durability...
Date Wed, 09 Mar 2016 15:23:32 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/79#discussion_r55533890
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ---
    @@ -2966,13 +2966,26 @@ public Void run() {
         }
       }
     
    +  private Durability getMincEventDurability(KeyExtent extent) {
    +    TableConfiguration conf;
    +    if (extent.isMeta() || extent.isRootTablet()) {
    --- End diff --
    
    > Is there some other setting for user tables that's more appropriate? 
    
    This is the best setting I know of... Since the walog minc entries are used during recovery,
its nice to have them at the same sync level as the tablets metadata.
    
    > so the || extent.isRootTablet() is redundant
    
    Nice catch, I wrongly assumed isMeta() was a more narrow check.  I used to know it did
a wider check, but had forgotten.  
    
    >  I think refactoring KeyExtent#isMeta is more appropriate
    
    Changing its name would need to be a separate PR, because it would be very noisy drowning
out the changes for 4112.  I agree another name that implies more than `accumulo.metadata`
would be good, however I am not sure what that name would be.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message