accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wjsl <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4112 use metadata table durability...
Date Wed, 09 Mar 2016 04:46:28 GMT
Github user wjsl commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/79#discussion_r55471617
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ---
    @@ -2966,13 +2966,26 @@ public Void run() {
         }
       }
     
    +  private Durability getMincEventDurability(KeyExtent extent) {
    +    TableConfiguration conf;
    +    if (extent.isMeta() || extent.isRootTablet()) {
    --- End diff --
    
    This check is a bit confusing. To me it reads "If the extent is for the metadata table
or the root tablet, use the root tablet's configuration. Otherwise, use the metadata configuration."
Is there some other setting for user tables that's more appropriate? 
    
    `KeyExtent#isMeta` already returns whether or not it's for the metadata table or the root
tablet, so the `|| extent.isRootTablet()` is redundant. However, I think refactoring `KeyExtent#isMeta`
is more appropriate to make it more clear about what it is checking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message