Return-Path: 
 <dev-return-14259-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 026EF1809F
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Mon, 29 Feb 2016 18:16:05 +0000 (UTC)
Received: (qmail 52282 invoked by uid 500); 29 Feb 2016 18:16:04 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 52225 invoked by uid 500); 29 Feb 2016 18:16:04 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 52191 invoked by uid 99); 29 Feb 2016 18:16:04 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Feb 2016 18:16:04 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 6107AE69BA; Mon, 29 Feb 2016 18:16:04 +0000 (UTC)
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-77-accumulo@git.apache.org>
In-Reply-To: <git-pr-77-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-4152 add fate dump command
Content-Type: text/plain
Message-Id: <20160229181604.6107AE69BA@git1-us-west.apache.org>
Date: Mon, 29 Feb 2016 18:16:04 +0000 (UTC)

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/77#discussion_r54451601
  
    --- Diff: shell/src/main/java/org/apache/accumulo/shell/commands/FateCommand.java ---
    @@ -53,6 +67,51 @@
     
       private static final String USER = "accumulo";
     
    +  // this class serializes references to interfaces with the concrete class name
    +  private static class InterfaceSerializer<T> implements JsonSerializer<T> {
    +    @Override
    +    public JsonElement serialize(T link, Type type, JsonSerializationContext context) {
    +      JsonElement je = context.serialize(link, link.getClass());
    +      JsonObject jo = new JsonObject();
    +      jo.add(link.getClass().getName(), je);
    +      return jo;
    +    }
    +  }
    +
    +  // the purpose of this class is to be serialized as JSon for display
    +  private static class ByteArrayContainer {
    +    @SuppressWarnings("unused")
    --- End diff --
    
    there is a comment for the class mentioning its used for Json serialization.... thats why the instance vars are not read


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---