accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjwall <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4138 Fix the description of -b opt...
Date Thu, 18 Feb 2016 20:26:57 GMT
GitHub user mjwall opened a pull request:

    https://github.com/apache/accumulo/pull/71

    ACCUMULO-4138 Fix the description of -b options

    It was wrong for FlushCommand and CompactCommand.  In the process of
    refactoring, the following was accomplished:
    
    - Change the description in the OptUtil.startRowOpt to be (NOT) inclusive.
    - Use OptUtil.startRowOpt in CompactCommand, MergeCommand and FlushCommand.
    - Refactor the DeleteRowCommand to use the OptUtil.startRowOpt method.
    - Refactor ScanCommand to override the description to say it is inclusive.
    
    Also updated the javadoc from a potential cut and paste on TableOperations.
    
    A little mixed on the usefulness of the Unit Tests for these.  They may be
    brittle, but perhaps they would alert if someone changed the way one command
    worked without looking at the others.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjwall/accumulo 4138-compact-command

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #71
    
----
commit 50db442b04f615ce698d0f63545917be6d4fb13c
Author: Michael Wall <mjwall@gmail.com>
Date:   2016-02-18T20:22:09Z

    ACCUMULO-4138 Fix the description of -b options
    
    It was wrong for FlushCommand and CompactCommand.  In the process of
    refactoring, the following was accomplished:
    
    - Change the description in the OptUtil.startRowOpt to be (NOT) inclusive.
    - Use OptUtil.startRowOpt in CompactCommand, MergeCommand and FlushCommand.
    - Refactor the DeleteRowCommand to use the OptUtil.startRowOpt method.
    - Refactor ScanCommand to override the description to say it is inclusive.
    
    Also updated the javadoc from a potential cut and paste on TableOperations.
    
    A little mixed on the usefulness of the Unit Tests for these.  They may be
    brittle, but perhaps they would alert if someone changed the way one command
    worked without looking at the others.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message