accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4152 add fate dump command
Date Mon, 29 Feb 2016 17:05:51 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/77#discussion_r54441340
  
    --- Diff: shell/src/main/java/org/apache/accumulo/shell/commands/FateCommand.java ---
    @@ -53,6 +67,51 @@
     
       private static final String USER = "accumulo";
     
    +  // this class serializes references to interfaces with the concrete class name
    +  private static class InterfaceSerializer<T> implements JsonSerializer<T>
{
    +    @Override
    +    public JsonElement serialize(T link, Type type, JsonSerializationContext context)
{
    +      JsonElement je = context.serialize(link, link.getClass());
    +      JsonObject jo = new JsonObject();
    +      jo.add(link.getClass().getName(), je);
    +      return jo;
    +    }
    +  }
    +
    +  // the purpose of this class is to be serialized as JSon for display
    +  private static class ByteArrayContainer {
    +    @SuppressWarnings("unused")
    --- End diff --
    
    Would be better to delete these, rather than suppress warnings. If they are needed, then
please add a comment explaining why they should be left in place with the warning suppression
(here, and other occurrences below).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message