accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlmarion <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-1755: Modified TSBW so that all cl...
Date Mon, 29 Feb 2016 15:43:07 GMT
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/75#discussion_r54426939
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
    @@ -699,7 +711,33 @@ else if (Tables.getTableState(context.getInstance(), table) == TableState.OFFLIN
     
         }
     
    -    void addMutations(MutationSet mutationsToSend) {
    +    void queueMutations(final MutationSet mutationsToSend) throws InterruptedException
{
    +      if (null == mutationsToSend)
    +        return;
    +      boolean transferred = queue.tryTransfer(new Runnable() {
    +        final MutationSet m = mutationsToSend;
    +
    +        @Override
    +        public void run() {
    +          if (null != m) {
    +            try {
    +              addMutations(m);
    +            } catch (Exception e) {
    +              updateUnknownErrors("Error processing mutation set", e);
    +            }
    +          }
    +        }
    +      });
    +      if (!transferred) {
    +        try {
    +          addMutations(mutationsToSend);
    --- End diff --
    
    Agreed. I believe that binning can be done concurrently. There is still a synchronization
point later, after the binning, but I believe that is the right place to block. I updated
this PR to make the Executor a daemon with a name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message