accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-1755: Modified TSBW so that all cl...
Date Mon, 29 Feb 2016 15:28:26 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/75#discussion_r54424394
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
    @@ -629,6 +639,8 @@ public void run() {
     
         private static final int MUTATION_BATCH_SIZE = 1 << 17;
         private final ExecutorService sendThreadPool;
    +    private final LinkedTransferQueue<Runnable> queue = new LinkedTransferQueue<>();
    +    private final ThreadPoolExecutor executor = new ThreadPoolExecutor(1, 1, 10L, TimeUnit.SECONDS,
queue);
    --- End diff --
    
    Would be nice to name thread.  Also it should be a daemon thread (I think it will not
be by default).  These are things I think that SimpleThreadPool does (may have name wrong,
you were using it earlier).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message