accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4152 add fate dump command
Date Sat, 27 Feb 2016 06:36:35 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/77#discussion_r54329410
  
    --- Diff: fate/src/main/java/org/apache/accumulo/fate/ZooStore.java ---
    @@ -458,4 +458,43 @@ public Serializable getProperty(long tid, String prop) {
           throw new RuntimeException(e);
         }
       }
    +
    +  @SuppressWarnings("unchecked")
    +  @Override
    +  public List<ReadOnlyRepo<T>> getStack(long tid) {
    +    String txpath = getTXPath(tid);
    +
    +    outer: while (true) {
    +      List<String> ops;
    +      try {
    +        ops = zk.getChildren(txpath);
    +      } catch (KeeperException.NoNodeException e) {
    +        return null;
    --- End diff --
    
    Oh, I see you check for null down below. I think an empty list would be nicer (less of
a chance for surprise), but would be happy with a javadoc update to `Store.getStack(long)`
that says it might return null (since this isn't user-facing).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message