accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-1755: Modified TSBW so that all cl...
Date Fri, 26 Feb 2016 23:39:51 GMT
Github user keith-turner commented on the pull request:

    https://github.com/apache/accumulo/pull/75#issuecomment-189526782
  
    > I added a catch clause to startProcessing to catch the RejectedExecutionException
that can be thrown. Were you thinking of something else?
    
    What you did is needed, but I was thinking of something else.   If the call to `addMutations()`
in the Runnable throws an unexpected exception, nothing will be done about that exception.
The batch writer should transition to an error state.  Thinking need to do something like
the following.
    
    ```java
    void queueMutations(final MutationSet mutationsToSend) {
          queueThreadPool.submit(new Runnable() {
            public void run() {
              try{
                addMutations(mutationsToSend);
              } catch (Exception e){
                updateUnknownErrors(e);
              }
            }
          });
        }
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message