accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-1755: Modified TSBW so that all cl...
Date Fri, 26 Feb 2016 19:52:54 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/75#discussion_r54292893
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
    @@ -699,7 +701,16 @@ else if (Tables.getTableState(context.getInstance(), table) == TableState.OFFLIN
     
         }
     
    -    void addMutations(MutationSet mutationsToSend) {
    +    void queueMutations(final MutationSet mutationsToSend) {
    +      queueThreadPool.submit(new Runnable() {
    --- End diff --
    
    > Are you suggesting re-using the existing ExecutorService?
    
    Nope. I'm saying just make a single thread which is reading off some queue. The clients
would be submitting mutations onto that queue. You just have one thread always running, looking
for mutations to add. You avoid the whole creating, scheduling and starting the Runnable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message