accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Marion <dlmar...@hotmail.com>
Subject Re: Review Request 43957: ACCUMULO-1755: removed synchronized modifier from TabletServerBatchWriterstartProcessing()
Date Thu, 25 Feb 2016 18:58:12 GMT


> On Feb. 25, 2016, 12:12 a.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java,
line 288
> > <https://reviews.apache.org/r/43957/diff/3/?file=1268425#file1268425line288>
> >
> >     Without sync I think the following can happen, which will result in a lost mutation.
> >     
> >      * Thread 1 calls mutations.get() 
> >      * Thread 2 bins/processes the mutation set that thread 1 has a local reference
to
> >      * Thread 1 adds a mutation to a dead mutation set that is already processed/binned.

Yeah - I see what you are saying here.


- Dave


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43957/#review120607
-----------------------------------------------------------


On Feb. 24, 2016, 11:10 p.m., Dave Marion wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43957/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 11:10 p.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-1755
>     https://issues.apache.org/jira/browse/ACCUMULO-1755
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-1755: removed synchronized modifier from TabletServerBatchWriterstartProcessing()
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
bc90d00 
> 
> Diff: https://reviews.apache.org/r/43957/diff/
> 
> 
> Testing
> -------
> 
> unit tests in core pass
> 
> 
> Thanks,
> 
> Dave Marion
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message