accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <>
Subject [GitHub] accumulo pull request: ACCUMULO-4153: Update the getCodec method t...
Date Wed, 24 Feb 2016 22:50:26 GMT
Github user madrob commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/
    @@ -147,25 +148,27 @@ public synchronized OutputStream createCompressionStream(OutputStream
    -      private transient DefaultCodec codec;
    +      private transient AtomicReference<DefaultCodec> codec = new AtomicReference<DefaultCodec>();
    -      synchronized CompressionCodec getCodec() {
    -        if (codec == null) {
    -          codec = new DefaultCodec();
    -          codec.setConf(conf);
    +      CompressionCodec getCodec() {
    +        DefaultCodec resultCodec = codec.get();
    +        if (null == resultCodec) {
    +          DefaultCodec newCodec = new DefaultCodec();
    --- End diff --
    The merit of creating it at construction time depends on how costly the initialization
is. I'm under the impression that it's not _that_ bad, so eager initialization is probably
ok here and we don't have to worry about concurrency at all. Good point, @brianloss.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message