accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4153: Update the getCodec method t...
Date Wed, 24 Feb 2016 21:21:42 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/73#issuecomment-188458189
  
    I apparently clicked through to the commit and left a bunch of comments instead of commenting
on the PR itself. Sorry about that.
    
    Overall, this looks pretty good. Some nit-picky things on the test case (yay, tests!)
and a similar recommendation to Marc's earlier note.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message