accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <>
Subject [GitHub] accumulo pull request: ACCUMULO-4143 Make protective copy of migra...
Date Thu, 11 Feb 2016 23:22:45 GMT
Github user ctubbsii commented on a diff in the pull request:
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/ ---
    @@ -1336,7 +1332,11 @@ public void assignedTablet(KeyExtent extent) {
    -  public Collection<KeyExtent> migrations() {
    -    return migrations.keySet();
    +  public Set<KeyExtent> migrations() {
    +    Set<KeyExtent> migrationsCopy = new HashSet<KeyExtent>();
    +    synchronized (migrations) {
    +      migrationsCopy.addAll(migrations.keySet());
    +    }
    +    return migrationsCopy;
    --- End diff --
    I'll go ahead and do the immutability, as well as rename the method... but I'll add a
Javadoc to clearly state that it's immutible. It looks like the other (test) implementations
are already immutable anyway.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message