accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4135 Add impersonation configurati...
Date Sat, 06 Feb 2016 07:57:16 GMT
Github user ctubbsii commented on the pull request:

    https://github.com/apache/accumulo/pull/67#issuecomment-180716575
  
    Just looking at the documentation change, it does seem to me that separating into two
configuration options and avoiding the prefix matching to grab configs is a bit more intuitive,
and I'm also in favor of moving the special characters out of configuration keys, even if
it's a simple special character like '/'. I usually prefer my configuration keys to look like
variable identifiers (though, dot-separated is okay). I haven't looked at the implementation,
but the test coverage looks good.
    
    Do you think you should go ahead and make the old version deprecated, for eventual removal,
since the old way is kind of flawed and we don't really want to have to maintain multiple
ways to configure the same thing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message