Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: phrocker <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
Message-ID: <git-pr-60-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3509: Allow cleanup state to
 be ke...
Content-Type: text/plain
Date: Fri,  1 Jan 2016 01:51:17 +0000 (UTC)

GitHub user phrocker opened a pull request:

    https://github.com/apache/accumulo/pull/60

    ACCUMULO-3509: Allow cleanup state to be kept to avoid blocking tserv…

    …er session sweep
    
    By enabling state ( true/false) from the cleanup method, the change will avoid blocking
    on a scan session being swept. if the session cleanup blocks because a ScanSession is
    still being read, we may block until the ScanBatch returns for that ScanSession.
    
    The change uses a simple semaphore ( purely because I like the word ) to attempt acquisition.
    If that fails, we return false from the cleanup and reintroduce that Session back into
    the queue to clean up.
    
    Added unit test that in the error condition will show the missing scan sessions ( which are missing due to the cleanup being blocked)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/accumulo-1 master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
    
----
commit bbd2257a001d654a87b433bb387ad9fce402dbb8
Author: phrocker <marc.parisi@gmail.com>
Date:   2015-12-31T15:16:49Z

    ACCUMULO-3509: Allow cleanup state to be kept to avoid blocking tserver session sweep
    
    By enabling state ( true/false) from the cleanup method, the change will avoid blocking
    on a scan session being swept. if the session cleanup blocks because a ScanSession is
    still being read, we may block until the ScanBatch returns for that ScanSession.
    
    The change uses a simple semaphore ( purely because I like the word ) to attempt acquisition.
    If that fails, we return false from the cleanup and reintroduce that Session back into
    the queue to clean up.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---