Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-60-accumulo@git.apache.org>
In-Reply-To: <git-pr-60-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3509: Allow cleanup state to
 be ke...
Content-Type: text/plain
Message-Id: <20160104171134.29DA0E0570@git1-us-west.apache.org>
Date: Mon,  4 Jan 2016 17:11:34 +0000 (UTC)

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/60#discussion_r48753936
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java ---
    @@ -38,100 +40,126 @@
       private ScanDataSource isolatedDataSource;
       private boolean sawException = false;
       private boolean scanClosed = false;
    +  protected Semaphore scannerSemaphore;
     
       Scanner(Tablet tablet, Range range, ScanOptions options) {
         this.tablet = tablet;
         this.range = range;
         this.options = options;
    +    scannerSemaphore = new Semaphore(1, true);
    --- End diff --
    
    The expense of fairness may not be a problem.  I suspect the expense of fairness is an issue for semaphores that are frequently accessed by many threads, which is not the case here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---