accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3509: Make cleanup stateful to min...
Date Mon, 04 Jan 2016 20:11:21 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/62#discussion_r48775109
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java ---
    @@ -1761,33 +1763,41 @@ Scanner createScanner(Range range, int num, Set<Column>
columns, Authorizations
         private ScanDataSource isolatedDataSource;
         private boolean sawException = false;
         private boolean scanClosed = false;
    +    private Semaphore scannerSemaphore;
    --- End diff --
    
    A javadoc comment describing why a semaphore is used would be nice when looking at this
code in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message