Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-59-accumulo@git.apache.org>
In-Reply-To: <git-pr-59-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3734 unescape auths when
 using Aut...
Content-Type: text/plain
Message-Id: <20151231170947.41B85E2C5A@git1-us-west.apache.org>
Date: Thu, 31 Dec 2015 17:09:47 +0000 (UTC)

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/59#discussion_r48663556
  
    --- Diff: core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java ---
    @@ -113,6 +123,31 @@ public void testQuote() {
       }
     
       @Test
    +  public void testUnescape() {
    +    assertEquals("a\"b", VisibilityEvaluator.unescape(new ArrayByteSequence("a\\\"b")).toString());
    +    assertEquals("a\\b", VisibilityEvaluator.unescape(new ArrayByteSequence("a\\\\b")).toString());
    +    assertEquals("a\\\"b", VisibilityEvaluator.unescape(new ArrayByteSequence("a\\\\\\\"b")).toString());
    +    assertEquals("\\\"", VisibilityEvaluator.unescape(new ArrayByteSequence("\\\\\\\"")).toString());
    +    assertEquals("a\\b\\c\\d", VisibilityEvaluator.unescape(new ArrayByteSequence("a\\\\b\\\\c\\\\d")).toString());
    +
    +    try {
    +      VisibilityEvaluator.unescape(new ArrayByteSequence("a\\b"));
    +      fail();
    --- End diff --
    
    An assertion message for the `fail()`'s would be nice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---