Return-Path: 
 <dev-return-13870-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5C11F18874
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Wed,  2 Dec 2015 00:09:17 +0000 (UTC)
Received: (qmail 95998 invoked by uid 500); 2 Dec 2015 00:09:17 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 95962 invoked by uid 500); 2 Dec 2015 00:09:17 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 95951 invoked by uid 99); 2 Dec 2015 00:09:16 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2015 00:09:16 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D04CFE052E; Wed,  2 Dec 2015 00:09:16 +0000 (UTC)
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-56-accumulo@git.apache.org>
In-Reply-To: <git-pr-56-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-4065 Work around TExceptions
 being...
Content-Type: text/plain
Message-Id: <20151202000916.D04CFE052E@git1-us-west.apache.org>
Date: Wed,  2 Dec 2015 00:09:16 +0000 (UTC)

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/56#discussion_r46360216
  
    --- Diff: proxy/src/main/java/org/apache/accumulo/proxy/Proxy.java ---
    @@ -135,7 +136,8 @@ public static TServer createProxyServer(Class<?> api, Class<?> implementor, fina
         @SuppressWarnings("unchecked")
    --- End diff --
    
    Before, this suppression was fine to do here, but I think the cast to `Class<TProcessor>` should be moved up to the assignment of `proxyProcClass` instead. That way, the cast here for the `Constructor` is unnecessary, and makes it easier to follow to the next line when the `Constructor` is instantiated with the `RpcWrapper`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---