accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-626 Iterator fuzzer/tester
Date Sun, 13 Dec 2015 22:54:15 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/50#discussion_r47451909
  
    --- Diff: iterator-test-harness/src/main/java/org/apache/accumulo/iteratortest/IteratorTestUtil.java
---
    @@ -0,0 +1,44 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.iteratortest;
    +
    +import java.util.Objects;
    +
    +import org.apache.accumulo.core.data.Key;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.accumulo.core.iterators.SortedKeyValueIterator;
    +import org.apache.accumulo.core.iterators.SortedMapIterator;
    +import org.apache.accumulo.core.iterators.system.ColumnFamilySkippingIterator;
    +import org.apache.accumulo.iteratortest.testcases.IteratorTestCase;
    +
    +/**
    + * A collection of methods that are helpful to the development of {@link IteratorTestCase}s.
    + */
    +public class IteratorTestUtil {
    +
    +  public static SortedKeyValueIterator<Key,Value> instantiateIterator(IteratorTestInput
input) {
    +    try {
    +      return Objects.requireNonNull(input.getIteratorClass()).newInstance();
    +    } catch (InstantiationException | IllegalAccessException e) {
    +      throw new RuntimeException(e);
    +    }
    +  }
    +
    +  public static SortedKeyValueIterator<Key,Value> createSource(IteratorTestInput
input) {
    +    return new ColumnFamilySkippingIterator(new SortedMapIterator(Objects.requireNonNull(input).getInput()));
    --- End diff --
    
    Turns out, this was a really good suggestion. Helped me find a bug in my test cases (need
to make sure to copy the Key-Value being emitted). The Tablet Scanner does this when converting
the Key and Value from the iterator stack into a `KeyValue`. Thanks again, Bill!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message