accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4065 Work around TExceptions being...
Date Wed, 02 Dec 2015 00:24:26 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/56#discussion_r46361599
  
    --- Diff: proxy/src/main/java/org/apache/accumulo/proxy/Proxy.java ---
    @@ -135,7 +136,8 @@ public static TServer createProxyServer(Class<?> api, Class<?>
implementor, fina
         @SuppressWarnings("unchecked")
         Constructor<? extends TProcessor> proxyProcConstructor = (Constructor<?
extends TProcessor>) proxyProcClass.getConstructor(proxyIfaceClass);
     
    -    final TProcessor processor = proxyProcConstructor.newInstance(RpcWrapper.service(impl));
    +    @SuppressWarnings({"rawtypes", "unchecked"})
    --- End diff --
    
    Neither rawtypes, nor unchecked are necessary to suppress here if we cast to `TBaseProcessor<?>`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message