accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4065 Work around TExceptions being...
Date Wed, 02 Dec 2015 00:04:14 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/56#discussion_r46359623
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ---
    @@ -3159,7 +3159,8 @@ private void returnMasterConnection(MasterClientService.Client client)
{
     
       private HostAndPort startTabletClientService() throws UnknownHostException {
         // start listening for client connection last
    -    Iface tch = RpcWrapper.service(new ThriftClientHandler());
    +    ThriftClientHandler handler = new ThriftClientHandler();
    +    Iface tch = RpcWrapper.service(handler, new Processor<Iface>(handler).getProcessMapView());
    --- End diff --
    
    For all of these calls, I think it's better to pass the Processor, and call the `getProcessMapView()`
in the method. It makes it a lot more readable, especially with all the generics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message