accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-4065 Work around TExceptions being...
Date Tue, 01 Dec 2015 17:37:48 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/56#discussion_r46310448
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
    @@ -36,20 +42,51 @@
      * @since 1.6.1
      */
     public class RpcWrapper {
    +  private static final Logger log = LoggerFactory.getLogger(RpcWrapper.class);
    +
    +  public static <T> T service(final T instance, @SuppressWarnings("rawtypes") final
Map<String,ProcessFunction<T,? extends TBase>> processorView) {
    +    // Get a handle on the isOnewayMethod and make it accessible
    +    final Method isOnewayMethod;
    +    try {
    +      isOnewayMethod = ProcessFunction.class.getDeclaredMethod("isOneway");
    +    } catch (NoSuchMethodException e) {
    +      throw new RuntimeException("Could not access isOneway method", e);
    +    } catch (SecurityException e) {
    +      throw new RuntimeException("Could not access isOneway method", e);
    +    }
    +    isOnewayMethod.setAccessible(true);
    --- End diff --
    
    No, we need it to be accessible to invoke the method later, I believe. I will double check
the API -- I don't use reflection enough to remember this all for certain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message