accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <>
Subject [GitHub] accumulo pull request: ACCUMULO-3948: Add Scanner classloader cont...
Date Mon, 16 Nov 2015 20:48:13 GMT
Github user keith-turner commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/ ---
    @@ -242,4 +242,31 @@
        * @since 1.8.0
       long getBatchTimeout(TimeUnit timeUnit);
    +  /**
    +   * Sets the name of the classloader context on this scanner. See the administration
chapter of the user manual for details on how to configure and use
    +   * classloader contexts.
    +   *
    +   * @param classLoaderContext
    +   *          name of the classloader context
    +   * @throws NullPointerException
    +   *           if context is null
    +   * @since 1.8.0
    +   */
    +  void setClassLoaderContext(String classLoaderContext);
    --- End diff --
    There are at least two ways to do this check.   Do it when setClassLoader is called. 
Or do it when the thrift calls startScan and continueScan are made.  An exception could be
added to these thrift calls.  How were you thinking of doing the check?
    For getting server side table props you can look into the implementation of `TableOperations.getProperties()`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message