accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <>
Subject [GitHub] accumulo pull request: ACCUMULO-3948: Add Scanner classloader cont...
Date Thu, 12 Nov 2015 18:52:37 GMT
Github user keith-turner commented on a diff in the pull request:
    --- Diff: test/src/main/java/org/apache/accumulo/test/functional/
    @@ -0,0 +1,233 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.test.functional;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertFalse;
    +import static org.junit.Assert.assertTrue;
    +import static;
    +import java.util.Collections;
    +import java.util.Iterator;
    +import java.util.Map.Entry;
    +import org.apache.accumulo.core.client.BatchScanner;
    +import org.apache.accumulo.core.client.BatchWriter;
    +import org.apache.accumulo.core.client.BatchWriterConfig;
    +import org.apache.accumulo.core.client.Connector;
    +import org.apache.accumulo.core.client.IteratorSetting;
    +import org.apache.accumulo.core.client.Scanner;
    +import org.apache.accumulo.core.conf.Property;
    +import org.apache.accumulo.core.util.CachedConfiguration;
    +import org.apache.accumulo.fate.util.UtilWaitThread;
    +import org.apache.accumulo.harness.AccumuloClusterHarness;
    +import org.apache.accumulo.minicluster.impl.MiniAccumuloClusterImpl;
    +import org.apache.hadoop.fs.FileSystem;
    +import org.apache.hadoop.fs.Path;
    +import org.hamcrest.CoreMatchers;
    +import org.junit.Assume;
    +import org.junit.Before;
    +import org.junit.Test;
    +public class ScannerContextIT extends AccumuloClusterHarness {
    --- End diff --
    A test to ensure there is no interference might be nice.  Something like the following
     * Create scanner 1
     * Create scanner 2
     * Set context on scanner 1
     * verify scanner 1 scans w/ context
     * verify scanner 2 scans w/o any context.
    Its not super important to have this test, it was just something I thought of.  It think
defends against odd leakage cases in the tablet server.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message