accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlmarion <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3948: Add Scanner classloader cont...
Date Thu, 12 Nov 2015 16:48:17 GMT
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/51#discussion_r44681496
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java ---
    @@ -242,4 +242,30 @@
        * @since 1.8.0
        */
       long getBatchTimeout(TimeUnit timeUnit);
    +
    +  /**
    +   * Sets the name of the classloader context on this scanner
    --- End diff --
    
    And if the section number is added to the javadoc, who updates the javadoc in the future
versions of the code when the manual changes? I would think that if you want to use the class
loader context feature, then you have probably already read the section in the manual to understand
how to configure it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message