accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3948: Add Scanner classloader cont...
Date Wed, 11 Nov 2015 18:02:35 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/51#discussion_r44563758
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/ScannerOptions.java
---
    @@ -244,4 +247,20 @@ public void setBatchTimeout(long timeout, TimeUnit timeUnit) {
       public long getBatchTimeout(TimeUnit timeUnit) {
         return timeUnit.convert(batchTimeOut, TimeUnit.MILLISECONDS);
       }
    +
    +  @Override
    +  public void setContext(String context) {
    +    this.context = context;
    --- End diff --
    
    >   However if we do not accept null (users must call clearContext insead)
    
    IMO, we either need to have clear javadoc on setContext about what a null context means
or just fail on null. I'd prefer the latter since there's an explicit clearContext method.
That gives us more flexibility in the future to hide behind the interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message