accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlmarion <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3948: Add Scanner classloader cont...
Date Wed, 11 Nov 2015 00:44:09 GMT
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/51#discussion_r44488494
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/ScannerOptions.java
---
    @@ -244,4 +247,20 @@ public void setBatchTimeout(long timeout, TimeUnit timeUnit) {
       public long getBatchTimeout(TimeUnit timeUnit) {
         return timeUnit.convert(batchTimeOut, TimeUnit.MILLISECONDS);
       }
    +
    +  @Override
    +  public void setContext(String context) {
    +    this.context = context;
    --- End diff --
    
    I could, but it's not an error to pass null. The reference is initialized to null and
is used successfully that way until it's set to something not null. Having said that, I don't
really care one way or the other, just curious if we are forcing the user to use the api in
a particular way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message