accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: added conf.isFile() check
Date Tue, 13 Oct 2015 20:54:32 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/48#issuecomment-147850773
  
    The code reads that ACCUMULO_CLIENT_CONF_PATH is meant to be a file (not a directory).
Maybe it would be good to also expand these changes to also include expanding it from a directory
to $directory/client.conf instead of just ignoring the value?
    
    A unit test would also be super appreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message