Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0834F177F1 for ; Tue, 22 Sep 2015 17:48:51 +0000 (UTC) Received: (qmail 19862 invoked by uid 500); 22 Sep 2015 17:48:50 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 19821 invoked by uid 500); 22 Sep 2015 17:48:50 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 19810 invoked by uid 99); 22 Sep 2015 17:48:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2015 17:48:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 67D44E0424; Tue, 22 Sep 2015 17:48:50 +0000 (UTC) From: keith-turner To: dev@accumulo.apache.org Reply-To: dev@accumulo.apache.org References: In-Reply-To: Subject: [GitHub] accumulo pull request: ACCUMULO-2232 Added options to Combiner for... Content-Type: text/plain Message-Id: <20150922174850.67D44E0424@git1-us-west.apache.org> Date: Tue, 22 Sep 2015 17:48:50 +0000 (UTC) Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/47#issuecomment-142362740 In 31fcf00 I changed the behaviour slightly. I dropped the option to throw an exception. I was thinking this option could prevent problems, but it can not. It can still only detect problems. For detecting problems I think logging an error is sufficient. I also changed logging to log on partial and full major compactions. If a full major compaction sees a delete, then its evidence that a problem could have occurred in the past with a partial compaction. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---