Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-47-accumulo@git.apache.org>
In-Reply-To: <git-pr-47-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-2232 Added options to
 Combiner for...
Content-Type: text/plain
Message-Id: <20150922044214.D4A0BE0362@git1-us-west.apache.org>
Date: Tue, 22 Sep 2015 04:42:14 +0000 (UTC)

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/47#discussion_r40052699
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/Combiner.java ---
    @@ -149,6 +159,37 @@ public void next() throws IOException {
     
       private Key workKey = new Key();
     
    +  private static Cache<String,Long> loggedMsgCache = CacheBuilder.newBuilder().expireAfterWrite(1, TimeUnit.HOURS).build();
    --- End diff --
    
    Would be safer to include a high-watermark on the size of the cache. Maybe 500 elements just to prevent catastrophic failure if we somehow create a bug that causes things to be added to this cache incorrectly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---