accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-2232 Added options to Combiner for...
Date Tue, 22 Sep 2015 04:43:55 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/47#discussion_r40052742
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/Combiner.java ---
    @@ -149,6 +159,37 @@ public void next() throws IOException {
     
       private Key workKey = new Key();
     
    +  private static Cache<String,Long> loggedMsgCache = CacheBuilder.newBuilder().expireAfterWrite(1,
TimeUnit.HOURS).build();
    +
    +  private void sawDelete() {
    +    if (isPartialCompaction) {
    +      switch (deleteHandlingAction) {
    +        case LOG_ERROR:
    +          try {
    +            loggedMsgCache.get(this.getClass().getName(), new Callable<Long>()
{
    +              @Override
    +              public Long call() throws Exception {
    +                log.error("Combiner of type " + this.getClass().getSimpleName()
    +                    + " saw a delete during a partial compaction.  This could cause undesired
results.  See ACCUMULO-2232.  Will not log subsequent occurences for at least 1 hour.");
    +                return System.currentTimeMillis();
    --- End diff --
    
    Do we really need the current time? Isn't `0` sufficient since we don't inspect the value
of the cache entries? A comment that the value returned by the Callable is meaningless would
also be nice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message