accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-2232 Added options to Combiner for...
Date Tue, 22 Sep 2015 04:35:52 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/47#discussion_r40052512
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/Combiner.java ---
    @@ -240,15 +299,18 @@ public void init(SortedKeyValueIterator<Key,Value> source,
Map<String,String> op
         newInstance.setSource(getSource().deepCopy(env));
         newInstance.combiners = combiners;
         newInstance.combineAllColumns = combineAllColumns;
    +    newInstance.isPartialCompaction = isPartialCompaction;
    +    newInstance.deleteHandlingAction = deleteHandlingAction;
         return newInstance;
       }
     
       @Override
       public IteratorOptions describeOptions() {
         IteratorOptions io = new IteratorOptions("comb", "Combiners apply reduce functions
to multiple versions of values with otherwise equal keys", null, null);
    -    io.addNamedOption(ALL_OPTION, "set to true to apply Combiner to every column, otherwise
leave blank. if true, " + COLUMNS_OPTION
    -        + " option will be ignored.");
    +    io.addNamedOption(ALL_OPTION,
    --- End diff --
    
    Nit: unrelated formatting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message