accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-2232 Added options to Combiner for...
Date Tue, 22 Sep 2015 04:35:31 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/47#discussion_r40052506
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/Combiner.java ---
    @@ -227,10 +271,25 @@ public void init(SortedKeyValueIterator<Key,Value> source,
Map<String,String> op
           throw new IllegalArgumentException("The " + COLUMNS_OPTION + " must not be empty");
     
         combiners = new ColumnSet(Lists.newArrayList(Splitter.on(",").split(encodedColumns)));
    +
    +    isPartialCompaction = ((env.getIteratorScope() == IteratorScope.majc) &&
!env.isFullMajorCompaction());
    +    if (options.containsKey(DELETE_HANDLING_ACTION_OPTION)) {
    +      deleteHandlingAction = DeleteHandlingAction.valueOf(options.get(DELETE_HANDLING_ACTION_OPTION));
    --- End diff --
    
    A warning message with the actual property being checked (DELETE_HANDLING_ACTION_OPTION)
and the value that we have no enum-value for would be useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message