accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3913 Added per table sampling
Date Tue, 15 Sep 2015 14:12:07 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/46#discussion_r39514233
  
    --- Diff: core/src/main/thrift/tabletserver.thrift ---
    @@ -164,8 +174,9 @@ service TabletClientService extends client.ClientService {
                                       5:map<string, map<string, string>> ssio,
                                       6:list<binary> authorizations,
                                       7:bool waitForWrites,
    -                                  9:i64 batchTimeOut)  throws (1:client.ThriftSecurityException
sec),
    -  data.MultiScanResult continueMultiScan(2:trace.TInfo tinfo, 1:data.ScanID scanID) throws
(1:NoSuchScanIDException nssi),
    +                                  9:TSamplerConfiguration samplerConfig,
    --- End diff --
    
    I think thats ok.  batchTimeOut is new in 1.8.0-SNAPSHOT.  At some point I merged it in
and I had a conflict and thats how I resolved it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message