accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3913 Added per table sampling
Date Tue, 15 Sep 2015 03:07:38 GMT
Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/46#issuecomment-140265688
  
    Ok, made it through the rest of the diffs. It looks good to me. I mentioned a couple of
nits, but I don't think any of them are blockers (I think IteratorEnvironment is already very
obtuse). I'll defer to your choice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message