accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3913 Added per table sampling
Date Tue, 15 Sep 2015 02:55:14 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/46#discussion_r39470086
  
    --- Diff: core/src/test/java/org/apache/accumulo/core/iterators/DefaultIteratorEnvironment.java
---
    @@ -18,17 +18,16 @@
     
     import java.io.IOException;
     
    +import org.apache.accumulo.core.client.impl.TestIteratorEnvironment;
     import org.apache.accumulo.core.conf.AccumuloConfiguration;
     import org.apache.accumulo.core.data.Key;
     import org.apache.accumulo.core.data.Value;
    -import org.apache.accumulo.core.iterators.IteratorUtil.IteratorScope;
     import org.apache.accumulo.core.iterators.system.MapFileIterator;
    -import org.apache.accumulo.core.security.Authorizations;
     import org.apache.accumulo.core.util.CachedConfiguration;
     import org.apache.hadoop.conf.Configuration;
     import org.apache.hadoop.fs.FileSystem;
     
    -public class DefaultIteratorEnvironment implements IteratorEnvironment {
    +public class DefaultIteratorEnvironment extends TestIteratorEnvironment {
    --- End diff --
    
    This seems like a peculiar change to make. The DefaultIE extends one for tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message