accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <>
Subject [GitHub] accumulo pull request: ACCUMULO-3913 Added per table sampling
Date Tue, 15 Sep 2015 02:52:43 GMT
Github user joshelser commented on a diff in the pull request:
    --- Diff: core/src/main/thrift/tabletserver.thrift ---
    @@ -164,8 +174,9 @@ service TabletClientService extends client.ClientService {
                                       5:map<string, map<string, string>> ssio,
                                       6:list<binary> authorizations,
                                       7:bool waitForWrites,
    -                                  9:i64 batchTimeOut)  throws (1:client.ThriftSecurityException
    -  data.MultiScanResult continueMultiScan(2:trace.TInfo tinfo, 1:data.ScanID scanID) throws
(1:NoSuchScanIDException nssi),
    +                                  9:TSamplerConfiguration samplerConfig,
    --- End diff --
    This is no good. You need to leave `batchTimeOut` as '9'. Can't change it to 10 w/o breaking
old clients.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message