accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3913 Added per table sampling
Date Tue, 15 Sep 2015 02:44:58 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/46#discussion_r39469628
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/compaction/CompactionSettings.java
---
    @@ -21,6 +21,7 @@
     
     public enum CompactionSettings {
     
    +  SF_NO_SAMPLE(new NullType()),
    --- End diff --
    
    Could have static instances of these, but I don't think it's necessary since they're wrapped
in the enum (e.g. we'd only have one instance anyways). Is that right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message