accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3913 Added per table sampling
Date Wed, 09 Sep 2015 18:06:35 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/46#discussion_r39076125
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
---
    @@ -297,4 +345,50 @@ public void setReadaheadThreshold(long batches) {
         }
         this.readaheadThreshold = batches;
       }
    +
    +  private SamplerConfiguration getIteratorSamplerConfigurationInternal() {
    +    SamplerConfiguration scannerSamplerConfig = getSamplerConfiguration();
    +    if (scannerSamplerConfig != null) {
    +      if (iteratorSamplerConfig != null && !new SamplerConfigurationImpl(iteratorSamplerConfig).equals(new
SamplerConfigurationImpl(scannerSamplerConfig))) {
    --- End diff --
    
    fixed in f6f60ad .   At one point `SamplerConfiguration` did not have `equals()` impl,
but now it does so I shortened it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message