accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3913 Added per table sampling
Date Sat, 05 Sep 2015 22:38:51 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/46#discussion_r38815459
  
    --- Diff: test/src/main/java/org/apache/accumulo/test/SampleIT.java ---
    @@ -0,0 +1,497 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.accumulo.test;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Map.Entry;
    +import java.util.Set;
    +import java.util.TreeMap;
    +
    +import org.apache.accumulo.core.client.AccumuloException;
    +import org.apache.accumulo.core.client.AccumuloSecurityException;
    +import org.apache.accumulo.core.client.BatchScanner;
    +import org.apache.accumulo.core.client.BatchWriter;
    +import org.apache.accumulo.core.client.BatchWriterConfig;
    +import org.apache.accumulo.core.client.ClientSideIteratorScanner;
    +import org.apache.accumulo.core.client.Connector;
    +import org.apache.accumulo.core.client.IsolatedScanner;
    +import org.apache.accumulo.core.client.IteratorSetting;
    +import org.apache.accumulo.core.client.MutationsRejectedException;
    +import org.apache.accumulo.core.client.SampleNotPresentException;
    +import org.apache.accumulo.core.client.Scanner;
    +import org.apache.accumulo.core.client.ScannerBase;
    +import org.apache.accumulo.core.client.TableNotFoundException;
    +import org.apache.accumulo.core.client.admin.CompactionConfig;
    +import org.apache.accumulo.core.client.admin.NewTableConfiguration;
    +import org.apache.accumulo.core.client.admin.SamplerConfiguration;
    +import org.apache.accumulo.core.client.impl.Credentials;
    +import org.apache.accumulo.core.client.impl.OfflineScanner;
    +import org.apache.accumulo.core.data.ByteSequence;
    +import org.apache.accumulo.core.data.Key;
    +import org.apache.accumulo.core.data.Mutation;
    +import org.apache.accumulo.core.data.Range;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.accumulo.core.iterators.IteratorEnvironment;
    +import org.apache.accumulo.core.iterators.SortedKeyValueIterator;
    +import org.apache.accumulo.core.iterators.WrappingIterator;
    +import org.apache.accumulo.core.sample.RowSampler;
    +import org.apache.accumulo.core.security.Authorizations;
    +import org.apache.accumulo.harness.AccumuloClusterHarness;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import com.google.common.collect.ImmutableMap;
    +import com.google.common.collect.Iterables;
    +
    +public class SampleIT extends AccumuloClusterHarness {
    +
    +  private static final Map<String,String> OPTIONS_1 = ImmutableMap.of("hasher",
"murmur3_32", "modulus", "1009");
    +  private static final Map<String,String> OPTIONS_2 = ImmutableMap.of("hasher",
"murmur3_32", "modulus", "997");
    +
    +  private static final SamplerConfiguration SC1 = new SamplerConfiguration(RowSampler.class.getName()).setOptions(OPTIONS_1);
    +  private static final SamplerConfiguration SC2 = new SamplerConfiguration(RowSampler.class.getName()).setOptions(OPTIONS_2);
    +
    +  public static class IteratorThatUsesSample extends WrappingIterator {
    +    private SortedKeyValueIterator<Key,Value> sampleDC;
    +    private boolean hasTop;
    +
    +    @Override
    +    public boolean hasTop() {
    +      return hasTop && super.hasTop();
    +    }
    +
    +    @Override
    +    public void seek(Range range, Collection<ByteSequence> columnFamilies, boolean
inclusive) throws IOException {
    +
    +      int sampleCount = 0;
    +      sampleDC.seek(range, columnFamilies, inclusive);
    +
    +      while (sampleDC.hasTop()) {
    +        sampleCount++;
    +        sampleDC.next();
    +      }
    +
    +      if (sampleCount < 10) {
    +        hasTop = true;
    +        super.seek(range, columnFamilies, inclusive);
    +      } else {
    +        // its too much data
    +        hasTop = false;
    +      }
    +    }
    +
    +    @Override
    +    public void init(SortedKeyValueIterator<Key,Value> source, Map<String,String>
options, IteratorEnvironment env) throws IOException {
    +      super.init(source, options, env);
    +
    +      IteratorEnvironment sampleEnv = env.newIEWithSamplingEnabled();
    --- End diff --
    
    Not a huge fan of this method name. A bit obtuse :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message