accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3913 Added per table sampling
Date Sat, 05 Sep 2015 22:27:01 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/46#discussion_r38815363
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
---
    @@ -297,4 +345,50 @@ public void setReadaheadThreshold(long batches) {
         }
         this.readaheadThreshold = batches;
       }
    +
    +  private SamplerConfiguration getIteratorSamplerConfigurationInternal() {
    +    SamplerConfiguration scannerSamplerConfig = getSamplerConfiguration();
    +    if (scannerSamplerConfig != null) {
    +      if (iteratorSamplerConfig != null && !new SamplerConfigurationImpl(iteratorSamplerConfig).equals(new
SamplerConfigurationImpl(scannerSamplerConfig))) {
    --- End diff --
    
    Can the instantiation of the objects in the equals method be broken out of the if condition?
There's a lot going on for a simple equality check that would be easier to follow if the impls
are instantiated earlier IMO


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message