Return-Path: 
 <dev-return-13391-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3B16218570
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Mon, 24 Aug 2015 18:32:11 +0000 (UTC)
Received: (qmail 52737 invoked by uid 500); 24 Aug 2015 18:32:11 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 52691 invoked by uid 500); 24 Aug 2015 18:32:11 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 52680 invoked by uid 99); 24 Aug 2015 18:32:10 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Aug 2015 18:32:10 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id AE11FE0616; Mon, 24 Aug 2015 18:32:10 +0000 (UTC)
From: dhutchis <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-44-accumulo@git.apache.org>
In-Reply-To: <git-pr-44-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Content-Type: text/plain
Message-Id: <20150824183210.AE11FE0616@git1-us-west.apache.org>
Date: Mon, 24 Aug 2015 18:32:10 +0000 (UTC)

Github user dhutchis commented on the pull request:

    https://github.com/apache/accumulo/pull/44#issuecomment-134330086
  
    Thanks for spotting that sentence Billie, will fix tonight.  It's good to
    throw in the rest of the Zipkin configuration as well (I was using the
    default localhost and port).
    
    On Mon, Aug 24, 2015 at 2:22 PM, billierinaldi <notifications@github.com>
    wrote:
    
    > This looks great. Thanks, Dylan! I have two suggestions. One is about the
    > sentence, "Span entries record full span information, whereas index and
    > start time entries provide indexing into span information useful for
    > quickly finding spans by type or start time." Actually both the span and
    > start time entries have the full span information, while only the index
    > entries provide indexing.
    >
    > The other suggestion is to mention other configuration properties that
    > would need to be set for the zipkin span receiver in accumulo-site.xml and
    > in the client configuration, such as:
    >
    > <property>
    >   <name>trace.span.receiver.zipkin.collector-hostname</name>
    >   <value>localhost</value>
    > </property>
    > <property>
    >   <name>trace.span.receiver.zipkin.collector-port</name>
    >   <value>9410</value>
    > </property>
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/accumulo/pull/44#issuecomment-134325576>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---