Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E8711182A1 for ; Mon, 17 Aug 2015 16:37:14 +0000 (UTC) Received: (qmail 9570 invoked by uid 500); 17 Aug 2015 16:36:16 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 9527 invoked by uid 500); 17 Aug 2015 16:36:16 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 9516 invoked by uid 99); 17 Aug 2015 16:36:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Aug 2015 16:36:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E33DAE024E; Mon, 17 Aug 2015 16:36:15 +0000 (UTC) From: joshelser To: dev@accumulo.apache.org Reply-To: dev@accumulo.apache.org References: In-Reply-To: Subject: [GitHub] accumulo pull request: Implementation of SeekingFilter, CfCqSliceF... Content-Type: text/plain Message-Id: <20150817163615.E33DAE024E@git1-us-west.apache.org> Date: Mon, 17 Aug 2015 16:36:15 +0000 (UTC) Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/42#issuecomment-131883366 :+1: this looks really good, Russ! Left a couple of comments in the code, but they were mainly stylistic than issues. I would love to also see an integration test that uses this iterator in a "real" environment, but that can be done as a follow-on. Your unit tests exercise this code very well already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---