accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhutchis <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3959 More accurate BatchScanner ja...
Date Mon, 24 Aug 2015 18:32:01 GMT
Github user dhutchis commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/45#discussion_r37785744
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/BatchScanner.java ---
    @@ -16,19 +16,20 @@
      */
     package org.apache.accumulo.core.client;
     
    +import org.apache.accumulo.core.data.Range;
    +
     import java.util.Collection;
     import java.util.concurrent.TimeUnit;
     
    -import org.apache.accumulo.core.data.Range;
    -
     /**
      * Implementations of BatchScanner support efficient lookups of many ranges in accumulo.
    + * BatchScanners are also appropriate for large, single ranges,
    + * as a BatchScanner will break those ranges up into separate RPCs
    + * provided the range spans more than one tablet
    + * and there are sufficiently many scan threads available.
      *
    - * Use this when looking up lots of ranges and you expect each range to contain a small
amount of data. Also only use this when you do not care about the
    - * returned data being in sorted order.
    - *
    - * If you want to lookup a few ranges and expect those ranges to contain a lot of data,
then use the Scanner instead. Also, the Scanner will return data in
    - * sorted order, this will not.
    + * Only use this when you do not care about returned data being in sorted order.
    --- End diff --
    
    Correct, I see that the <p> tag is necessary from the online javadoc at
    http://accumulo.apache.org/1.7/apidocs/org/apache/accumulo/core/client/BatchScanner.html
    
    Will fix tonight when I return to my laptop.  I don't think my editor
    (IntelliJ with the Eclipse code formatter plugin) adds the HTML tags
    automatically.
    
    On Mon, Aug 24, 2015 at 2:25 PM, Keith Turner <notifications@github.com>
    wrote:
    
    > In core/src/main/java/org/apache/accumulo/core/client/BatchScanner.java
    > <https://github.com/apache/accumulo/pull/45#discussion_r37784571>:
    >
    > >   *
    > > - * Use this when looking up lots of ranges and you expect each range to contain
a small amount of data. Also only use this when you do not care about the
    > > - * returned data being in sorted order.
    > > - *
    > > - * If you want to lookup a few ranges and expect those ranges to contain a
lot of data, then use the Scanner instead. Also, the Scanner will return data in
    > > - * sorted order, this will not.
    > > + * Only use this when you do not care about returned data being in sorted order.
    >
    > This was already broken before your patch, but I think javadoc need <p>
    > markup for paragraphs. Not sure it will render as intended w/o it.
    >
    > Did you format these changes?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/accumulo/pull/45/files#r37784571>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message